Post by ADD Creative » Tue Aug 15, 2017 5:49 pm

Could be this issue. https://github.com/opencart/opencart/issues/1991

There are a few solutions. Backup your files and database before testing. Create a test product when trying out, that way it wont matter if it's deleted.

www.add-creative.co.uk


Expert Member

Posts

Joined
Sat Jan 14, 2012 1:02 am
Location - United Kingdom

Post by davidliu » Sun Aug 27, 2017 7:44 pm

Bank transfer payments Confirm Order return:
Failed to load resource: the server responded with a status of 500 (Internal Server Error)

Attachments

fail.png

Failed to load resource: the server responded with a status of 500 (Internal Server Error) - fail.png (5.93 KiB) Viewed 5411 times


Newbie

Posts

Joined
Sun Aug 27, 2017 7:38 pm

Post by ADD Creative » Tue Aug 29, 2017 10:09 pm

davidliu wrote:
Sun Aug 27, 2017 7:44 pm
Bank transfer payments Confirm Order return:
Failed to load resource: the server responded with a status of 500 (Internal Server Error)
Works OK for me. Could it be caused by an extension or theme?

www.add-creative.co.uk


Expert Member

Posts

Joined
Sat Jan 14, 2012 1:02 am
Location - United Kingdom

Post by Cue4cheap » Wed Apr 29, 2020 12:35 am

Right up front I'll say I read all posts in this topic. And yes I know the last post was 2017 and yes I know version 3.X is out.
With that being said I have upgraded to 2.3.0.2 because it doesn't have TWIG and was what advice I was given as the best opencart version to upgrade to.

So now my question is: Does the first post have all the bug fixes for 2.3.0.2? Straight away it doesn't look like it does because around post 40 Qphoria has an update for the catalog/model/extension/total/credit.php file to have:

Code: Select all

$credit = min($balance, $total); 
Changed to

Code: Select all

$credit = min($balance, $total['total']);
And I don't see that as a fix on the first post. There are a few others too that I see in the posts that are not on the first post.
So if the first post doesn't have all the bug fixes for 2.3.0.2 is there a post that does? Or a version that does?

Thank you,
Mike
Last edited by straightlight on Wed Apr 29, 2020 12:47 am, edited 1 time in total.
Reason: Added code tags.

cue4cheap not cheap quality


Active Member

Posts

Joined
Fri Sep 20, 2013 4:45 am

Post by ADD Creative » Wed Apr 29, 2020 1:14 am

No, the first post doesn't have all the bug fixes, there is a lot more than what is listed. I don't think there will be any place that list them all, it will most likely be a case of fixing them as you find them.

www.add-creative.co.uk


Expert Member

Posts

Joined
Sat Jan 14, 2012 1:02 am
Location - United Kingdom

Post by straightlight » Wed Apr 29, 2020 1:18 am

This topic is pretty old. It does provide multiple fixes but officially to let everyone know to look for them as we go is still the right way. Alternatively, the master branch contains the most updated fixes in anyhow but may still provide no guarantee whatsoever for OC users using older OC releases.

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by Johnathan » Wed Apr 29, 2020 10:45 pm

I added a link to the version with bug fixes to the first post, so it would be a bit more visible. If people experience issues with it let a mod know and we can remove it, but I've only heard good things from it at this point.

Image
Image Image Image Image


User avatar
Global Moderator

Posts

Joined
Fri Dec 18, 2009 3:08 am


Post by straightlight » Wed Apr 29, 2020 10:48 pm

Followed from Johnathan's post;

The provided links on the first post prior on today's modifications are still valid. It's just that they aren't updated with all the bug-fixes since that topic was created nor may have they been updated since the release of OC v3.x releases.

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by salwa123 » Mon Jun 14, 2021 5:57 pm

straightlight wrote:
Mon Aug 01, 2016 9:50 pm
This will be the official Opencart v2.3.0.2 bug reports topic to report any issues from the core.

UNOFFICIAL VERSION OF OPENCART 2.3.0.2 WITH BUG FIXES:
https://github.com/condor2/Opencart_2302

LIST OF CONFIRMED BUGS AND SOLUTIONS:
BUG: Deleting a language causes Error: Table banner_image_description doesn't exist

FIX (4722):
- EDIT: admin/model/localisation/language.php
- CHANGE (line 222):
from:

Code: Select all

$this->db->query("DELETE FROM " . DB_PREFIX . "banner_image_description WHERE language_id = '" . (int)$language_id . "'");
to:

Code: Select all

$this->db->query("DELETE FROM " . DB_PREFIX . "banner_image WHERE language_id = '" . (int)$language_id . "'");
BUG: Error: Could not load model total!

Two-part bug. Part one: Event Compatibility cuts off too many parts of the route when trying to load the older extension format. ex. "extension/total/sub_total/getTotal" route gets turned into "total/sub_total" instead of "total/sub_total/getTotal". This causes it to try and load a model with no name throwing the exception. Part Two, this compatibility is being loaded fine when the route is "extension/total/subtotal" but is also loading when the route is "extension/total/sub_total/getTotal". I think this event should not be triggered for compatibility because it is a getTotal is a function call, not a model load. This causes the verification to fail and try to load the 2.2.x version which has other bits missing and throws different errors. Haven't figured out why the function call is going down the event path. But basically the attempt to support backwards compatibility with 2.2 mods is causing problems.

2 Solutions

FIX 1: Give up on 2.2.x compatibility and delete the following left-over folders:

Code: Select all

    catalog/model/total
    catalog/model/payment
    catalog/controller/payment
    catalog/model/shipping
    catalog/controller/module
    admin/controller/total
    admin/controller/payment
    admin/controller/shipping
    admin/controller/module
FIX 2: Add a hack to bypass the event when the function call for "getTotal", "getMethod", or "getQuote" are passed in. This is experimental but should at least restore support for 2.2.x mods for now. This is NOT a permanent fix. Just a work around.
EDIT: catalog/controller/event/compatibility.php
FIND:

Code: Select all

'model/' . $route. '.php'
REPLACE WITH:

Code: Select all

'model/' . ((strpos($route,'get') !== false) ? dirname($route) : $route) . '.php'
This should let routes like "extension/total/sub_total" work but block "extension/total/sub_total/getTotal" calls which fail on the directory check.
BUG: When enabled, fraud modules cause an error to be thrown during order completion, which can prevent the order from being fully completed. The error message thrown is: "Call to a member function check() on a non-object in /catalog/model/checkout/order.php"

FIX: http://forum.opencart.com/viewtopic.php ... 93#p638230

List of confirmed previous fixes that wasn't added from v2.2.0.0 release:

- Missing checkout 1st part validation process: http://forum.opencart.com/viewtopic.php ... 29#p617203

- Shipping checkout address fix: http://forum.opencart.com/viewtopic.php ... 59#p625959

- Admin orders customer notification email fix: http://forum.opencart.com/viewtopic.php ... 56#p632395

- Bugfix by artcore: http://forum.opencart.com/viewtopic.php ... 20#p632732
In fact, the version solved a lot of problems, but for the administrator, why were some things deleted.. Is this version considered certified and free of hacking software.. Which version is clean?
Why aren't the problems resolved so that they can be explained to the user?
And the most important improvement is that it solved the problem of PHP7.4.20 support .. Why is there no solution for everyone to be applied?

Active Member

Posts

Joined
Fri Mar 04, 2016 6:01 pm

Post by straightlight » Mon Jun 14, 2021 7:05 pm

salwa123 wrote:
Mon Jun 14, 2021 5:57 pm
straightlight wrote:
Mon Aug 01, 2016 9:50 pm
This will be the official Opencart v2.3.0.2 bug reports topic to report any issues from the core.

UNOFFICIAL VERSION OF OPENCART 2.3.0.2 WITH BUG FIXES:
https://github.com/condor2/Opencart_2302

LIST OF CONFIRMED BUGS AND SOLUTIONS:
BUG: Deleting a language causes Error: Table banner_image_description doesn't exist

FIX (4722):
- EDIT: admin/model/localisation/language.php
- CHANGE (line 222):
from:

Code: Select all

$this->db->query("DELETE FROM " . DB_PREFIX . "banner_image_description WHERE language_id = '" . (int)$language_id . "'");
to:

Code: Select all

$this->db->query("DELETE FROM " . DB_PREFIX . "banner_image WHERE language_id = '" . (int)$language_id . "'");
BUG: Error: Could not load model total!

Two-part bug. Part one: Event Compatibility cuts off too many parts of the route when trying to load the older extension format. ex. "extension/total/sub_total/getTotal" route gets turned into "total/sub_total" instead of "total/sub_total/getTotal". This causes it to try and load a model with no name throwing the exception. Part Two, this compatibility is being loaded fine when the route is "extension/total/subtotal" but is also loading when the route is "extension/total/sub_total/getTotal". I think this event should not be triggered for compatibility because it is a getTotal is a function call, not a model load. This causes the verification to fail and try to load the 2.2.x version which has other bits missing and throws different errors. Haven't figured out why the function call is going down the event path. But basically the attempt to support backwards compatibility with 2.2 mods is causing problems.

2 Solutions

FIX 1: Give up on 2.2.x compatibility and delete the following left-over folders:

Code: Select all

    catalog/model/total
    catalog/model/payment
    catalog/controller/payment
    catalog/model/shipping
    catalog/controller/module
    admin/controller/total
    admin/controller/payment
    admin/controller/shipping
    admin/controller/module
FIX 2: Add a hack to bypass the event when the function call for "getTotal", "getMethod", or "getQuote" are passed in. This is experimental but should at least restore support for 2.2.x mods for now. This is NOT a permanent fix. Just a work around.
EDIT: catalog/controller/event/compatibility.php
FIND:

Code: Select all

'model/' . $route. '.php'
REPLACE WITH:

Code: Select all

'model/' . ((strpos($route,'get') !== false) ? dirname($route) : $route) . '.php'
This should let routes like "extension/total/sub_total" work but block "extension/total/sub_total/getTotal" calls which fail on the directory check.
BUG: When enabled, fraud modules cause an error to be thrown during order completion, which can prevent the order from being fully completed. The error message thrown is: "Call to a member function check() on a non-object in /catalog/model/checkout/order.php"

FIX: http://forum.opencart.com/viewtopic.php ... 93#p638230

List of confirmed previous fixes that wasn't added from v2.2.0.0 release:

- Missing checkout 1st part validation process: http://forum.opencart.com/viewtopic.php ... 29#p617203

- Shipping checkout address fix: http://forum.opencart.com/viewtopic.php ... 59#p625959

- Admin orders customer notification email fix: http://forum.opencart.com/viewtopic.php ... 56#p632395

- Bugfix by artcore: http://forum.opencart.com/viewtopic.php ... 20#p632732
In fact, the version solved a lot of problems, but for the administrator, why were some things deleted.. Is this version considered certified and free of hacking software.. Which version is clean?
Why aren't the problems resolved so that they can be explained to the user?
And the most important improvement is that it solved the problem of PHP7.4.20 support .. Why is there no solution for everyone to be applied?
These bug-fixes have nothing to do with hack-proof. The reason why no solution for everyone is applied is because each servers are specifics where a great mount of people it could work but other people might not without further troubleshooting.

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON
Who is online

Users browsing this forum: No registered users and 5 guests