Post by xxvirusxx » Sun May 31, 2020 8:45 pm

ADD Creative wrote:
Sun May 31, 2020 8:39 pm
This technically wrong. The from address for the contact form should be the store owners email address and the reply-to the customer's. As the email will be sent via the store owners server or SMTP server, it would be impossible to match the SPF records of the customer email domain or be DKIM signed for the customer email domain. As more and more hosts add outgoing SMTP filters there will be a greater chance the emails will be rejected as spam.
I think is a topic about that :)
Maybe will be improvment, because same is also in Master.

- admin/view/template/catalog/product_form.twig. Duplicate >

Code: Select all

html += '    <select name="product_recurring[' + recurring_row + '][customer_group_id]" class="form-control">>';
lines: 1585, 1595
https://github.com/opencart/opencart/pull/7100/files

- Login url incorrect on customer approval email
viewtopic.php?t=205221

- Quantity check if is integer?
https://github.com/opencart/opencart/co ... f4a245c8b2

Upgrade Service | OC 2.3.0.2 PHP 8 | My Custom OC 3.0.3.8 | Buy me a beer


User avatar
Expert Member

Posts

Joined
Tue Jul 17, 2012 10:35 pm
Location - România

Post by straightlight » Sun May 31, 2020 8:55 pm

xxvirusxx wrote:
Sun May 31, 2020 8:45 pm
- admin/view/template/catalog/product_form.twig. Duplicate >

Code: Select all

html += '    <select name="product_recurring[' + recurring_row + '][customer_group_id]" class="form-control">>';
lines: 1585, 1595
https://github.com/opencart/opencart/pull/7100/files

- Login url incorrect on customer approval email
viewtopic.php?t=205221
Fixed.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

User avatar
Expert Member

Posts

Joined
Tue Jul 17, 2012 10:35 pm
Location - România

Post by straightlight » Sun May 31, 2020 8:58 pm

xxvirusxx wrote:
Sun May 31, 2020 8:45 pm
- Quantity check if is integer?
https://github.com/opencart/opencart/co ... f4a245c8b2
Jesse made the change. The master branch does not have this change yet: https://github.com/opencart/opencart/bl ... t/cart.php .

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by straightlight » Sun May 31, 2020 9:00 pm

xxvirusxx wrote:
Sun May 31, 2020 8:56 pm
- Login in to customer account bug
https://github.com/opencart/opencart/co ... 6d02190fa4
Fixed.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by xxvirusxx » Sun May 31, 2020 9:05 pm

straightlight wrote:
Sun May 31, 2020 8:58 pm
Jesse made the change. The master branch does not have this change yet: https://github.com/opencart/opencart/bl ... t/cart.php .
Ignore that :)

- Missing public from function
https://github.com/opencart/opencart/issues/7432
https://github.com/opencart/opencart/co ... 78ac4cb7b9

Upgrade Service | OC 2.3.0.2 PHP 8 | My Custom OC 3.0.3.8 | Buy me a beer


User avatar
Expert Member

Posts

Joined
Tue Jul 17, 2012 10:35 pm
Location - România

Post by straightlight » Sun May 31, 2020 9:08 pm


Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by xxvirusxx » Sun May 31, 2020 9:09 pm

Typo destroy function

https://github.com/opencart/opencart/issues/7522
https://github.com/opencart/opencart/co ... 5aba2e3402

You have re-uploaded on github?

- catalog/model/extension/total/sub_total.php, you miss this 'sort_order' => $this->config->get('sub_total_sort_order')
Last edited by xxvirusxx on Sun May 31, 2020 9:15 pm, edited 1 time in total.

Upgrade Service | OC 2.3.0.2 PHP 8 | My Custom OC 3.0.3.8 | Buy me a beer


User avatar
Expert Member

Posts

Joined
Tue Jul 17, 2012 10:35 pm
Location - România

Post by straightlight » Sun May 31, 2020 9:15 pm

xxvirusxx wrote:
Sun May 31, 2020 9:09 pm
Typo destroy function

https://github.com/opencart/opencart/issues/7522
https://github.com/opencart/opencart/co ... 5aba2e3402

You have re-uploaded on github?
Definitely a major. Fixed. I will post an update once we gather enough fix regarding the next upload of the package. I don't want to update real time too often as I want to leave the time for users to try the package and report the issues.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by xxvirusxx » Sun May 31, 2020 9:19 pm

ok.

Check model/sub_total for prevision reply

- this small optimization?: catalog/model/extension/shipping/weight.php
https://github.com/opencart/opencart/co ... 1c2c324184

Upgrade Service | OC 2.3.0.2 PHP 8 | My Custom OC 3.0.3.8 | Buy me a beer


User avatar
Expert Member

Posts

Joined
Tue Jul 17, 2012 10:35 pm
Location - România

Post by straightlight » Sun May 31, 2020 9:21 pm

xxvirusxx wrote:
Sun May 31, 2020 9:19 pm
ok.

Check model/sub_total for prevision reply

- this small optimization?: catalog/model/extension/shipping/weight.php
https://github.com/opencart/opencart/co ... 1c2c324184
Fixed.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by ADD Creative » Sun May 31, 2020 9:23 pm

straightlight wrote:
Sun May 31, 2020 8:43 pm
This fix was handled by Jesse on Github: https://github.com/opencart/opencart/bl ... ontact.php . It is using the $this->request->post['email'] . You'll have to address this issue on the Github Opencart issues tab.
I did and also someone else pointed out it was wrong. https://github.com/opencart/opencart/pull/6594

Also here is stated as some hosts will not send email from other addreses https://github.com/opencart/opencart/is ... -239400277

Putting the customer's email address as the from address seems to be a workaround for a bug in some Microsoft email clients that ignore the reply-to address. Hopefully Microsoft will have fixed that by now.

www.add-creative.co.uk


Expert Member

Posts

Joined
Sat Jan 14, 2012 1:02 am
Location - United Kingdom

Post by xxvirusxx » Sun May 31, 2020 9:27 pm

Sitemap updated to Master Branch?: catalog/controller/extension/feed/google_sitemap.php
LE. Was removed...
Last edited by straightlight on Sun May 31, 2020 9:37 pm, edited 2 times in total.
Reason: Attachment removed since it has nothing to do with the master branch.

Upgrade Service | OC 2.3.0.2 PHP 8 | My Custom OC 3.0.3.8 | Buy me a beer


User avatar
Expert Member

Posts

Joined
Tue Jul 17, 2012 10:35 pm
Location - România

Post by straightlight » Sun May 31, 2020 9:28 pm

ADD Creative wrote:
Sun May 31, 2020 9:23 pm
straightlight wrote:
Sun May 31, 2020 8:43 pm
This fix was handled by Jesse on Github: https://github.com/opencart/opencart/bl ... ontact.php . It is using the $this->request->post['email'] . You'll have to address this issue on the Github Opencart issues tab.
I did and also someone else pointed out it was wrong. https://github.com/opencart/opencart/pull/6594

Also here is stated as some hosts will not send email from other addreses https://github.com/opencart/opencart/is ... -239400277

Putting the customer's email address as the from address seems to be a workaround for a bug in some Microsoft email clients that ignore the reply-to address. Hopefully Microsoft will have fixed that by now.
I have addressed this issue to Daniel regarding those two variables especially since the $this->request->post['email'] has already been added on the master branch. Based on his decision, an update will be posted.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by straightlight » Sun May 31, 2020 9:30 pm

xxvirusxx wrote:
Sun May 31, 2020 9:27 pm
Sitemap updated to Master Branch?: catalog/controller/extension/feed/google_sitemap.php
LE. Was removed...
Where on the master branch? I don't see the feed folder: https://github.com/opencart/opencart/tr ... /extension .

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by xxvirusxx » Sun May 31, 2020 9:38 pm

<< Link removed >>. Now considered a third-party extension.

-Admin location store bug?
https://github.com/opencart/opencart/issues/7442

-Removed unused parameter
https://github.com/opencart/opencart/issues/7510
Last edited by straightlight on Sun May 31, 2020 9:42 pm, edited 1 time in total.
Reason: Removed site_map link. No longer in the master branch.

Upgrade Service | OC 2.3.0.2 PHP 8 | My Custom OC 3.0.3.8 | Buy me a beer


User avatar
Expert Member

Posts

Joined
Tue Jul 17, 2012 10:35 pm
Location - România

Post by straightlight » Sun May 31, 2020 9:42 pm

xxvirusxx wrote:
Sun May 31, 2020 9:38 pm
<< Link removed >>. Now considered a third-party extension.

-Admin location store bug?
https://github.com/opencart/opencart/issues/7442
It has been removed due to administrative decision to consider this file to be used from the Marketplace or from a third-party website as an extension. This topic is NOT for extensions. Please stick on the topic !!

As for the locations, fixed.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by straightlight » Sun May 31, 2020 9:44 pm

Moved the $frequencies array list above the foreach statements instead of inside.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

User avatar
Expert Member

Posts

Joined
Tue Jul 17, 2012 10:35 pm
Location - România

Post by straightlight » Sun May 31, 2020 9:57 pm

Order Statistics: Fixed.

I have also fixed the oc_event for the statistics to load /before instead of /after.

Marketplace Extension fix: It's still on hold on Github on that one.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON
Who is online

Users browsing this forum: No registered users and 255 guests