Post by nightwing » Fri Mar 19, 2021 9:54 pm

Hi Team, I have been on this thread viewtopic.php?f=202&t=205325&p=817120#p816816 for the past few days, however @sw!tch asked me to create a new post regarding this issue as he believes this is separate from the issue originally reported.
In my 3.0.3.2 default theme install, I noticed that the sub-total is always at first place in the cart total, I went ahead and applied the fixes listed here:
https://github.com/opencart/opencart/co ... c42d0eabc8
https://github.com/opencart/opencart/co ... 9dde938612
https://github.com/opencart/opencart/co ... 704aa7aeba

After applying the fixes, I was able to at least save a sort order number in the admin panel but I noticed that when I change the sort order number from anything but 0 the order order totals such as Shipping, Store Credit disappears. When its set to 0 it goes to the top and everything works and calculated as expected.

When sub_total sort order is 0
https://ibb.co/d7VvPG9

When sub_total sort order is not 0, for example 6
https://ibb.co/6HJqqBP

I reinstalled the extension, refreshed the modification, cleared all caches, still no difference

I am kindly seeking some assistance to troubleshoot and resolve this issue.
Thanks

Regards,
Nightwing
Access to my Free Extensions: https://www.opencart.com/index.php?rout ... =nightwing


Active Member

Posts

Joined
Tue Nov 05, 2019 11:08 pm


Post by straightlight » Fri Mar 19, 2021 10:19 pm

Already fixed on both branches. You're addressing an issue based on an older OC release version.

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member
Online

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by nightwing » Fri Mar 19, 2021 10:30 pm

Ok, I assume downloading the files from there and directly uploading to my install would fix? I downloaded a copy of 3.0.3.7 and replaced my files and the issue is still the same.
straightlight wrote:
Fri Mar 19, 2021 10:19 pm
Already fixed on both branches. You're addressing an issue based on an older OC release version.

Regards,
Nightwing
Access to my Free Extensions: https://www.opencart.com/index.php?rout ... =nightwing


Active Member

Posts

Joined
Tue Nov 05, 2019 11:08 pm


Post by nightwing » Fri Mar 19, 2021 10:31 pm

What would be the part I am missing out? As all these patches came from the github fixes.
nightwing wrote:
Fri Mar 19, 2021 10:30 pm
Ok, I assume downloading the files from there and directly uploading to my install would fix? I downloaded a copy of 3.0.3.7 and replaced my files and the issue is still the same.
straightlight wrote:
Fri Mar 19, 2021 10:19 pm
Already fixed on both branches. You're addressing an issue based on an older OC release version.

Regards,
Nightwing
Access to my Free Extensions: https://www.opencart.com/index.php?rout ... =nightwing


Active Member

Posts

Joined
Tue Nov 05, 2019 11:08 pm


Post by nightwing » Fri Mar 19, 2021 11:13 pm

I installed 3.0.3.7 and noted the following
This issue only occurs when the other total sort order values are lower than that of the sub total.

Thanks

Regards,
Nightwing
Access to my Free Extensions: https://www.opencart.com/index.php?rout ... =nightwing


Active Member

Posts

Joined
Tue Nov 05, 2019 11:08 pm


Post by sw!tch » Sat Mar 20, 2021 12:28 am

So you have a different problem in 3.0.3.7 ?

Full Stack Web Developer :: Send a PM for Custom Work.
Backup and learn how to recover before you make any changes!


Active Member

Posts

Joined
Sat Apr 28, 2012 2:32 pm
Location - USA

Post by nightwing » Sat Mar 20, 2021 12:50 am

Hi sw!tch, I am not sure if this is a problem anymore, its the same when you fix 3.0.3.2, sort order for sub-total must be lower than all other totals
sw!tch wrote:
Sat Mar 20, 2021 12:28 am
So you have a different problem in 3.0.3.7 ?

Regards,
Nightwing
Access to my Free Extensions: https://www.opencart.com/index.php?rout ... =nightwing


Active Member

Posts

Joined
Tue Nov 05, 2019 11:08 pm


Post by nightwing » Sat Mar 20, 2021 1:03 am

No its the same, once sort order is below the others, they disappear. I think probably I had it wrong overall.
sw!tch wrote:
Sat Mar 20, 2021 12:28 am
So you have a different problem in 3.0.3.7 ?

Regards,
Nightwing
Access to my Free Extensions: https://www.opencart.com/index.php?rout ... =nightwing


Active Member

Posts

Joined
Tue Nov 05, 2019 11:08 pm


Post by straightlight » Sat Mar 20, 2021 1:22 am

nightwing wrote:
Fri Mar 19, 2021 10:31 pm
What would be the part I am missing out? As all these patches came from the github fixes.
nightwing wrote:
Fri Mar 19, 2021 10:30 pm
Ok, I assume downloading the files from there and directly uploading to my install would fix? I downloaded a copy of 3.0.3.7 and replaced my files and the issue is still the same.
straightlight wrote:
Fri Mar 19, 2021 10:19 pm
Already fixed on both branches. You're addressing an issue based on an older OC release version.
Yes, from the maintenance and master branch, bug-fixes are already implicit to what you're describing. The reason why OC v3.0.3.7 still contains these bugs is because releases are being deployed separately from the branches whereas the author of the distribution for OC v3.0.3.7 has been congratulated from: https://www.opencart.com/opencart/opencart/releases by its founder. Therefore, I would rather suggest to focus on the maintenance branch for bug-fixes until the master branch is officially ready (no official date release).

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member
Online

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by nightwing » Sat Mar 20, 2021 3:52 am

Ah I see, thanks for the info.
straightlight wrote:
Sat Mar 20, 2021 1:22 am
nightwing wrote:
Fri Mar 19, 2021 10:31 pm
What would be the part I am missing out? As all these patches came from the github fixes.
nightwing wrote:
Fri Mar 19, 2021 10:30 pm
Ok, I assume downloading the files from there and directly uploading to my install would fix? I downloaded a copy of 3.0.3.7 and replaced my files and the issue is still the same.

Yes, from the maintenance and master branch, bug-fixes are already implicit to what you're describing. The reason why OC v3.0.3.7 still contains these bugs is because releases are being deployed separately from the branches whereas the author of the distribution for OC v3.0.3.7 has been congratulated from: https://www.opencart.com/opencart/opencart/releases by its founder. Therefore, I would rather suggest to focus on the maintenance branch for bug-fixes until the master branch is officially ready (no official date release).

Regards,
Nightwing
Access to my Free Extensions: https://www.opencart.com/index.php?rout ... =nightwing


Active Member

Posts

Joined
Tue Nov 05, 2019 11:08 pm

Who is online

Users browsing this forum: No registered users and 8 guests