Post by Fkdhwb » Wed May 12, 2021 2:09 am

Opencart 3.0.3.6
Vanilla Install
File: catalog/view/theme/default/checkout.twig
Line 243:

Code: Select all

var shipping_address = $('#payment-address input[name=\'shipping_address\']:checked').prop('value');
Should be:

Code: Select all

var shipping_address = $('#collapse-payment-address input[name=\'shipping_address\']:checked').prop('value');
Otherwise shipping_address is always undefined regardless of whether you check the box.

Newbie

Posts

Joined
Sun Jan 26, 2020 11:28 pm

Post by straightlight » Wed May 12, 2021 2:58 am

This should be reported on Github Opencart repository. Confirmed from the Maintenance Branch as well. Issue was not resolved:

Code: Select all

                var shipping_address = $('#payment-address input[name=\'shipping_address\']:checked').prop('value');
                

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by Fkdhwb » Wed May 12, 2021 4:28 am

I have posted the issue on github.

Newbie

Posts

Joined
Sun Jan 26, 2020 11:28 pm

Post by mikeinterserv » Wed May 12, 2021 4:33 am

Well this must be caused by something else.
I have 3.0.3.6 and 3.0.3.2 versions working fine without issue with that line of code unchanged.

Active Member

Posts

Joined
Thu May 28, 2020 6:55 am
Location - Wales

Post by straightlight » Wed May 12, 2021 7:25 am

He's not wrong though because a few lines above from the core, it is showing the collapse element of the same key.

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by ADD Creative » Wed May 12, 2021 6:08 pm

Fkdhwb wrote:
Wed May 12, 2021 2:09 am
Opencart 3.0.3.6
Vanilla Install
File: catalog/view/theme/default/checkout.twig
Line 243:
var shipping_address = $('#payment-address input[name=\'shipping_address\']:checked').prop('value');
Should be:
var shipping_address = $('#collapse-payment-address input[name=\'shipping_address\']:checked').prop('value');

Otherwise shipping_address is always undefined regardless of whether you check the box.
Good spot. Without this fix the the customer is taken to step 3 even if they have checked that the delivery and billing addresses are the same. With the fix they are correctly taken straight to to step 4. Not a major issue, but anything that saves the customer time at checkout is a good thing.

Also affects version 2.x.

www.add-creative.co.uk


Active Member

Posts

Joined
Sat Jan 14, 2012 1:02 am
Location - United Kingdom
Who is online

Users browsing this forum: No registered users and 6 guests