Post by straightlight » Tue Sep 21, 2021 8:46 am

It was brought to our attention that a major incident was discovered on Github Opencart repository as it has been rectified today. admin/view/template/sale/order_form.twig file may require some attention in order for everyone all using OC v3.x releases (it might also involve prior versions) to follow this bug-fix solution: https://github.com/opencart/opencart/co ... e82a10776a .

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by ADD Creative » Tue Sep 21, 2021 4:44 pm

This is not a major incident. You do know that the </tbody> can be omitted anyway?

https://html.spec.whatwg.org/multipage/ ... dy-element
A tbody element's end tag can be omitted if the tbody element is immediately followed by a tbody or tfoot element, or if there is no more content in the parent element.
It's been like that since version 2 and causes absolute no issues. It was even reported back if February.
https://github.com/opencart/opencart/pull/9359

www.add-creative.co.uk


Expert Member

Posts

Joined
Sat Jan 14, 2012 1:02 am
Location - United Kingdom

Post by straightlight » Tue Sep 21, 2021 7:17 pm

ADD Creative wrote:
Tue Sep 21, 2021 4:44 pm
This is not a major incident. You do know that the </tbody> can be omitted anyway?

https://html.spec.whatwg.org/multipage/ ... dy-element
A tbody element's end tag can be omitted if the tbody element is immediately followed by a tbody or tfoot element, or if there is no more content in the parent element.
It's been like that since version 2 and causes absolute no issues. It was even reported back if February.
https://github.com/opencart/opencart/pull/9359
It's still a major since this step on the platform is before the last one that needs review before heading back on the order information. Store owners may not realize what's going on since the </tbody> tag was put inside the IF statement while the <tbody> was put before the IF statement. The old functionality of APIs also relies on this, as opposed to the master branch, and may still affect the users regardless of the stores they're using.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by ADD Creative » Tue Sep 21, 2021 7:32 pm

You have not understood at all. There is no way a missing tbody end tag could cause any sort of problem.

www.add-creative.co.uk


Expert Member

Posts

Joined
Sat Jan 14, 2012 1:02 am
Location - United Kingdom

Post by straightlight » Tue Sep 21, 2021 8:06 pm

ADD Creative wrote:
Tue Sep 21, 2021 7:32 pm
You have not understood at all. There is no way a missing tbody end tag could cause any sort of problem.
If I wouldn't understand the problem, then the commit wouldn't be merged by now.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by ADD Creative » Tue Sep 21, 2021 10:23 pm

The end tag is optional in HTML but good practice to include it for code consistency and readability. That's why it was merged. Not because it caused any issues.

www.add-creative.co.uk


Expert Member

Posts

Joined
Sat Jan 14, 2012 1:02 am
Location - United Kingdom

Post by straightlight » Tue Sep 21, 2021 10:42 pm

Regardless, it affects everyone using the two series on anyhow.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON
Who is online

Users browsing this forum: No registered users and 76 guests