Post by nightwing » Thu Feb 04, 2021 10:02 pm

Yes, I was explaining that when I tested with regex, it replaced the entire line.
I used this from your original vqmod:

Code: Select all

~(<form[^>]*method\s*=\s*["\']post["\'][^>]*>)~i
straightlight wrote:
Wed Feb 03, 2021 8:32 am
nightwing wrote:
Wed Feb 03, 2021 8:22 am
I get you... Hmm that cannot be used then as I see tags with <form method and <form action... If this is what you mean
straightlight wrote:
Wed Feb 03, 2021 7:46 am


As explained on the above, it would be the ordering priority entered by the user when using the element names on the <form line.
They both can and must be used to import the CSRF token but the only difference is the way they're being entered by the user as priority for each element names which is why the use of regex is eminent in this case.

Regards,
Nightwing
Access to my Free Extensions: https://www.opencart.com/index.php?rout ... =nightwing


Active Member

Posts

Joined
Tue Nov 05, 2019 11:08 pm


Post by straightlight » Thu Feb 04, 2021 10:28 pm

nightwing wrote:
Thu Feb 04, 2021 10:02 pm
Yes, I was explaining that when I tested with regex, it replaced the entire line.
I used this from your original vqmod:

Code: Select all

~(<form[^>]*method\s*=\s*["\']post["\'][^>]*>)~i
straightlight wrote:
Wed Feb 03, 2021 8:32 am
nightwing wrote:
Wed Feb 03, 2021 8:22 am
I get you... Hmm that cannot be used then as I see tags with <form method and <form action... If this is what you mean

They both can and must be used to import the CSRF token but the only difference is the way they're being entered by the user as priority for each element names which is why the use of regex is eminent in this case.
However, the e.g you were showing are still able tracking lines individually with OCMod where OCMod is on its way of deprecation from the core in the future.

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by nightwing » Thu Feb 04, 2021 10:32 pm

Well its tracking the lines, and replacing them even when I used add position after. I am aware that its on its way to deprecation, but for now its needed.
straightlight wrote:
Thu Feb 04, 2021 10:28 pm
nightwing wrote:
Thu Feb 04, 2021 10:02 pm
Yes, I was explaining that when I tested with regex, it replaced the entire line.
I used this from your original vqmod:

Code: Select all

~(<form[^>]*method\s*=\s*["\']post["\'][^>]*>)~i
straightlight wrote:
Wed Feb 03, 2021 8:32 am


They both can and must be used to import the CSRF token but the only difference is the way they're being entered by the user as priority for each element names which is why the use of regex is eminent in this case.
However, the e.g you were showing are still able tracking lines individually with OCMod where OCMod is on its way of deprecation from the core in the future.

Regards,
Nightwing
Access to my Free Extensions: https://www.opencart.com/index.php?rout ... =nightwing


Active Member

Posts

Joined
Tue Nov 05, 2019 11:08 pm


Post by straightlight » Fri Feb 05, 2021 1:48 am

nightwing wrote:
Thu Feb 04, 2021 10:32 pm
Well its tracking the lines, and replacing them even when I used add position after. I am aware that its on its way to deprecation, but for now its needed.
straightlight wrote:
Thu Feb 04, 2021 10:28 pm
nightwing wrote:
Thu Feb 04, 2021 10:02 pm
Yes, I was explaining that when I tested with regex, it replaced the entire line.
I used this from your original vqmod:

Code: Select all

~(<form[^>]*method\s*=\s*["\']post["\'][^>]*>)~i
However, the e.g you were showing are still able tracking lines individually with OCMod where OCMod is on its way of deprecation from the core in the future.
It's good, at least, you figured out your own way to make it work but, as said, going back the way it was won't help the people on how it works since, over the years, it is more than obvious that they don't know since those changes you specified are still about server-specific tracking.

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by nightwing » Fri Feb 05, 2021 2:51 am

Lol :laugh: Sraightlight, I have nit figured it out!
Its removing the form tag and replacing it with the hidden input, in otherwords, its not doing the correct thing even when I add position after and not replace.
straightlight wrote:
Fri Feb 05, 2021 1:48 am
nightwing wrote:
Thu Feb 04, 2021 10:32 pm
Well its tracking the lines, and replacing them even when I used add position after. I am aware that its on its way to deprecation, but for now its needed.
straightlight wrote:
Thu Feb 04, 2021 10:28 pm


However, the e.g you were showing are still able tracking lines individually with OCMod where OCMod is on its way of deprecation from the core in the future.
It's good, at least, you figured out your own way to make it work but, as said, going back the way it was won't help the people on how it works since, over the years, it is more than obvious that they don't know since those changes you specified are still about server-specific tracking.

Regards,
Nightwing
Access to my Free Extensions: https://www.opencart.com/index.php?rout ... =nightwing


Active Member

Posts

Joined
Tue Nov 05, 2019 11:08 pm


Post by straightlight » Fri Feb 05, 2021 2:53 am

nightwing wrote:
Fri Feb 05, 2021 2:51 am
Lol :laugh: Sraightlight, I have nit figured it out!
Its removing the form tag and replacing it with the hidden input, in otherwords, its not doing the correct thing even when I add position after and not replace.
straightlight wrote:
Fri Feb 05, 2021 1:48 am
nightwing wrote:
Thu Feb 04, 2021 10:32 pm
Well its tracking the lines, and replacing them even when I used add position after. I am aware that its on its way to deprecation, but for now its needed.

It's good, at least, you figured out your own way to make it work but, as said, going back the way it was won't help the people on how it works since, over the years, it is more than obvious that they don't know since those changes you specified are still about server-specific tracking.
The old version used too. You're simply trying to fallback but can't seem to reproduce the ways it used to be. That's fine, since there doesn't seem to be any way out on this one since the deprecation of OCMod.

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by nightwing » Fri Feb 05, 2021 2:58 am

Thanks for the info. If I figure anything out, I will share with you.
straightlight wrote:
Fri Feb 05, 2021 2:53 am
nightwing wrote:
Fri Feb 05, 2021 2:51 am
Lol :laugh: Sraightlight, I have nit figured it out!
Its removing the form tag and replacing it with the hidden input, in otherwords, its not doing the correct thing even when I add position after and not replace.
straightlight wrote:
Fri Feb 05, 2021 1:48 am


It's good, at least, you figured out your own way to make it work but, as said, going back the way it was won't help the people on how it works since, over the years, it is more than obvious that they don't know since those changes you specified are still about server-specific tracking.
The old version used too. You're simply trying to fallback but can't seem to reproduce the ways it used to be. That's fine, since there doesn't seem to be any way out on this one since the deprecation of OCMod.

Regards,
Nightwing
Access to my Free Extensions: https://www.opencart.com/index.php?rout ... =nightwing


Active Member

Posts

Joined
Tue Nov 05, 2019 11:08 pm

Who is online

Users browsing this forum: Bing [Bot] and 3 guests