can`t view images after upload

If full screen works fine at 755 why not just leave it there?

Qphoria wrote: If full screen works fine at 755 why not just leave it there?

bruce wrote: Your english is fine.

you will need to change the save function in library\filesystem\upload.php as follows

Code: Select all

	function save($key, $file)
	{
		if (file_exists($file))
		{
			@unlink($file);
		}
		$status = @move_uploaded_file($_FILES[$key]['tmp_name'], $file);
		if ($status)
			chmod($file, 0644);
		return $status;
	}	

hm2k wrote: Further more, you only need to make it readable by all, you can use a+r

All this aside, I am on the understanding that you need to set the permissions of new files somewhere.

fido-x wrote: That's the same as 0644

Pardon? Do you mean, after uploading an image through the admin, that I then have to log in using a terminal or ftp client to set the correct permissions? If that is the case, why have an image upload function?

Permissions on the uploaded file are set by the server operator (apache) for the owner to read and write, but the group and everyone else can't. Remember, you are NOT the owner of the uploaded files, the server operator is.

hm2k wrote: I think you should read up on chmod. I think you mean 644.

There's a setting in many operating systems and web servers that tells the system what permissions new files should have. For example, his system is probably set to something like 444, where as if new files were set to 644, he wouldn't be seeing this problem.

[Session]
; Handler used to store/retrieve data.
session.save_handler = files

; Argument passed to save_handler.  In the case of files, this is the path
; where data files are stored. Note: Windows users have to change this
; variable in order to use PHP's session functions.
;
; As of PHP 4.0.1, you can define the path as:
;
;     session.save_path = "N;/path"
;
; where N is an integer.  Instead of storing all the session files in
; /path, what this will do is use subdirectories N-levels deep, and
; store the session data in those directories.  This is useful if you
; or your OS have problems with lots of files in one directory, and is
; a more efficient layout for servers that handle lots of sessions.
;
; NOTE 1: PHP will not create this directory structure automatically.
;         You can use the script in the ext/session dir for that purpose.
; NOTE 2: See the section on garbage collection below if you choose to
;         use subdirectories for session storage
;
; The file storage module creates files using mode 600 by default.
; You can change that by using
;
;     session.save_path = "N;MODE;/path"
;
; where MODE is the octal representation of the mode. Note that this
; does not overwrite the process's umask.
session.save_path = /var/lib/php

fido-x wrote: No. I mean 644. It is the last number that sets the permission for "everybody else". The numbers represent permissions for owner, group, and everybody else - in that order.

On all current PHP versions, move_uploaded_file() creates a
destination file that is either mode 0600 or 0644 (on Linux,
anyway), depending on whether move_uploaded_file() needed to copy
the file across filesystems.

If the file can be moved (renamed), then the resulting file is mode
0600, because the file was originally created with mkstemp. If the
file needs to be copied, the resulting mode is 0644 instead
(assuming a "normal" umask of 022).

fido-x wrote: I found this comment -

On all current PHP versions, move_uploaded_file() creates a
destination file that is either mode 0600 or 0644 (on Linux,
anyway), depending on whether move_uploaded_file() needed to copy
the file across filesystems.

If the file can be moved (renamed), then the resulting file is mode
0600, because the file was originally created with mkstemp. If the
file needs to be copied, the resulting mode is 0644 instead
(assuming a "normal" umask of 022).

at http://bugs.php.net/bug.php?id=42291

You should use @copy() instead of @move_uploaded_file().

hm2k wrote: Sure, but then you'd have to unlink the temp file too... so copy()&unlink() vs move_uploaded_file()&chmod() really...