This topic is about how to report bug-fixes for this release. Users who will be testing this release are being amended to report all issues on the Opencart Github > issues tab: https://github.com/opencart/opencart/issues .
Official topic to see test the package: viewtopic.php?f=2&p=788947#p788947 .
Followed is the massive change log, I suppose, everybody was expecting to have after many years:
Code: Select all
[June 25, 2020 - 6:52pm - (EST Time) - Core - Update]: Fixed Catalog Theme parameters.
Code: Select all
Change log:
admin:
- admin language common column left: admin/language/en-gb/common/column_left.php - removed older 3rd party extension language definitions.
- admin startup controller: admin/controller/startup/startup.php - removed openbay.
- admin startup permission controller: admin/controller/startup/permission.php - removed openbay, advertise from google hangouts and google shopping.
- admin common filemanager controller: admin/controller/common/filemanager.php - replaced entire file and ensured no language key from master branch were involved on this release.
- admin language mail voucher: admin/language/en-gb/sale/voucher.php - removed text_sent array key.
catalog:
- catalog startup controller: catalog/controller/startup/startup.php - removed openbay.
install:
- install step_2 controller: install/controller/install/step_2.php - removed older DB libraries from the $db array.
- install cli installer: install/cli_install.php - switched PHP version from 5.4 to 7.1.
- install step_4 language: install/language/en-gb/install/step_4.php - removed older 3rd party extension language definitions.
system:
- system config catalog: system/config/catalog.php - removed openbay from library_autoload.
vendor:
- Array of older features: system/storage/vendor/composer/autoload_static.php
- Array of older features: system/storage/vendor/composer/autoload_namespaces.php
---
FIX:
Admin:
- language cache: admin/model/localisation/language.php - fixed cache conventional names causing an increase in the error logs and added SEO URL deletion in deleteLanguage() method.
- admin sale order controller: admin/controller/sale/order.php - fixed option weight from string to decimal value of 0.00 and fixed the api_token and api_key validations. Replaced error/not_found or return new Action('error/not_found') codes with: $this->load->controller('error/not_found'). Also fixed the $product_option_value_info validation.
- fixed convention of getOrderVouchers to read: getVouchers.
- admin sale recurring controller: admin/controller/sale/recurring.php - - replaced error/not_found or return new Action('error/not_found') codes with: $this->load->controller('error/not_found')
- admin sale order TWIG order info: admin/view/template/sale/order_info.twig - renamed 'token' to array key name: 'api_token' and removed all Openbay instances and JS functions.
- admin marketplace extension detection drop-down menu controller: admin/controller/marketplace/extension.php - fixed the heading_title(0) count issue.
- admin design layout controller: admin/controller/design/layout.php file - added $part[0] as switch case in the $this->load->language call.
- admin model tool image: admin/model/tool/image.php - removed 'image/' and replaced with generic detection based on the DIR_IMAGE constant entered by the store owner.
- admin model tool upload: admin/model/tool/upload.php - replaced error/not_found or return new Action('error/not_found') codes with: $this->load->controller('error/not_found')
- admin common security TWIG file: admin/view/template/common/security.twig - renamed {{text_security }} to {{ text_security }}
- admin event statistics controller: admin/controller/event/statistics.php - renamed all commented out text as per the master branch.
- admin marketing contact controller: admin/controller/marketing/contact.php - added new $email_total arrays as per the master branch.
- admin language mail voucher: admin/language/en-gb/mail/voucher.php - moved text_sent key to this language definition.
- admin design layout form TWIG file: admin/view/template/design/layout/translation_form.twig - replaced JS functions with the ones from the master branch by keeping the same CSS elements.
- admin design layout list TWIG file: admin/view/template/design/layout/translation_list.twig - replaced JS functions with the ones from the master branch by keeping the same CSS elements.
- admin extension payment free checkout TWIG file: admin/view/template/extension/payment/free_checkout.twig - fixed free_checkout to read: payment_free_checkout.
- admin extension payment free checkout controller: admin/controller/extension/payment/free_checkout.php - fixed free_checkout to read: payment_free_checkout.
- admin marketing coupon controller: admin/controller/marketing/coupon.php - fixed various codes.
- admin language sale order controller: admin/language/en-gb/sale/order.php - fixed order ID # string originating from sprintf.
- admin extension report product viewed controller: admin/controller/extension/report/product_viewed.php - fixed $data['reset'] URL string.
- admin extension dashboard chart controller: admin/controller/extension/dashboard/chart.php - fixed dashboard_chart_width array key.
- admin common dashboard TWIG file: admin/view/template/common/dashboard.twig - fixed button_developer ID and link.
- admin customer controller: admin/controller/customer/customer.php - replaced error/not_found or return new Action('error/not_found') codes with: $this->load->controller('error/not_found')
- admin marketplace controller: admin/controller/marketplace/marketplace.php - replaced error/not_found or return new Action('error/not_found') codes with: $this->load->controller('error/not_found')
- admin model user: admin/model/user/user.php - STILL REQUIRES FIXING ON GITHUB - CAUSING MYSQLi FETCH ARRAY TO APPEAR IN THE ADMIN!
- admin model customer: admin/model/customer/customer.php - CAUSING MYSQLi FETCH ARRAY TO APPEAR IN THE ADMIN!
- admin report online TWIG file: admin/view/template/report/online.twig - fixed IP address lookup URL with http://www.geoiptool.com/en/?IP= .
- admin customer customer_ip TWIG file: admin/view/template/customer/customer_ip.twig - fixed IP address lookup URL with http://www.geoiptool.com/en/?IP= .
- admin common column_left controller: admin/controller/common/column_left.php - fixed model reports with floats as per the master branch.
- admin localisation location list TWIG file: admin/view/template/localisation/location_list.twig - fixed locations to location in the for loop.
- admin localisation location controller: admin/controller/localisation/location.php - fixed location to locations in the $data and the foreach loop.
- admin customer controller: admin/controller/customer/customer.php - fixed various issues.
- Fixed validation for localisation and value IDs as per the master branch.
- admin customer custom fields controller: admin/controller/customer/custom_field - fixed customer groups validation fields as per the master branch.
- admin mail customer controller: admin/controller/mail/customer.php - Fixed $data['login'] to affect $store_url as the URL in the approve() method.
- admin product form TWIG file: admin/view/template/catalog/product_form.twig - fixed select ending double tags with single tags.
- Fixed JS lookups as per the master branch.
- admin affiliate mail approve language: admin/language/en-gb/mail/affiliate_approve.php - fixed text_services to read: text_service.
- admin sale return controller: admin/controller/sale/return.php - fixed sort_status URL from sort=status to sort=return_status.
- admin model sale return: admin/model/sale/return.php - fixed sort_status filter from sort=status to sort=return_status.
- admin common dashboard security controller: admin/controller/common/dashboard.php - fixed common/developer for common/security in permission validation.
- admin model catalog product: admin/model/catalog/product.php - fixed conventional names.
- admin model catalog filter: admin/model/catalog/filter.php - fixed duplicated getDescriptions method and changed the filter group model to getGroupDescriptions as per the master branch.
- admin catalog filter controller: admin/controller/catalog/filter.php - fixed filter group model call to read getGroupDescriptions.
- admin marketing coupon controller: admin/controller/marketing/coupon.php - fixed getCouponHistories to read getHistories.
- admin mail controller: admin/controller/mail/affiliate*, admin/controller/mail/customer* - fixed missing $data variables and added logo for HTML emails.
- admin mail language: admin/controller/mail/affiliate*, admin/controller/mail/customer* - fixed missing language definitions.
- admin view mail template: admin/view/template/mail/affiliate*, admin/controller/mail/customer* - replaced text templates with HTML templates.
- admin customer controller: admin/controller/customer/customer.php - fixed affiliate tracking validation.
- admin model seo_url: admin/model/design/seo_url - fixed sort by query key.
- admin localisation country en-gb language: admin/language/en-gb/localisation/country.php - removed error_affiliate entry.
- admin localisation zone en-gb language: admin/language/en-gb/localisation/zone.php - removed error_affiliate entry.
- admin sale recurring controller: admin/controller/sale/recurring.php - fixed sort recurring_id string for or.order_recurring_id.
- admin catalog attribute groups controller: admin/controller/catalog/attribute_group.php - fixed conventional name to use the new name of: getGroupDescriptions.
Catalog:
- catalog mail order controller page: catalog/controller/mail/order.php - Added $this->load->model('checkout/order'); in index(...) and alert(...)
- catalog model tool image: catalog/model/tool/image.php - removed 'image/' and replaced with generic detection based on the DIR_IMAGE constant entered by the store owner.
- catalog model total voucher extension order complete statuses - catalog/model/extension/total/voucher.php - switched from IN to OR in the SQL statement. Added false status if no imploded order complete statuses can also be found.
- catalog login controller validation page: catalog/controller/account/login.php - added email validation in the validate method.
- catalog login language: catalog/language/en-gb/account/login.php - added error_email definition.
- catalog model checkout recurring: catalog/model/checkout/recurring.php - fixed addRecurring INSERT SQL statement with the $data recurring keys.
- catalog checkout controller: catalog/controller/checkout/checkout.php - removed older 3rd party extension payment lookups.
- catalog event statistics controller: catalog/controller/event/statistics.php - replaced all commented out text as per the master branch.
- catalog event debug controller: catalog/controller/event/debug.php - replaced the debug controller with the master branch version.
- catalog event activity controller: catalog/controller/event/activity.php - fixed addOrderHistory method by referring to master branch and fixed commented out text information.
- catalog view checkout guest TWIG file: catalog/view/theme/default/template/checkout/guest.twig - fixed custom fields placeholder element.
- catalog account order controller: catalog/controller/account/order.php - replaced error/not_found or return new Action('error/not_found') codes with: $this->load->controller('error/not_found')
- catalog account tracking controller: catalog/controller/account/tracking.php - replaced error/not_found or return new Action('error/not_found') codes with: $this->load->controller('error/not_found')
- catalog account login controller: catalog/controller/account/login.php - fixed login and redirection validations.
- catalog affiliate login controller: catalog/controller/affiliate/login.php - fixed login and redirection validations.
- catalog pp braintree extension payment TWIG file: catalog/view/theme/default/template/extension/payment/pp_braintree.twig - replaced with id="discover-logo".
- catalog model extension shipping weight: catalog/model/extension/shipping/weight.php - moved $this->cart->getWeight() before loop.
- catalog model setting extension: catalog/model/setting/extension.php - fixed function with public function call.
- catalog model extension total sub-total: catalog/model/extension/total/sub_total.php - fixed $this->config->get total_ prefix.
- catalog mail controller: catalog/controller/mail/affiliate*, catalog/controller/mail/customer* - fixed missing $data variables and added logo for HTML emails.
- catalog mail language: catalog/controller/mail/affiliate*, catalog/controller/mail/customer* - fixed missing language definitions.
- catalog view mail template: catalog/view/template/mail/affiliate*, catalog/controller/mail/customer* - replaced text templates with HTML templates.
System:
- system library mail SMTP: system/library/mail/smtp.php - replaced it with the master branch' version.
- system library cache: system/library/cache/file.php - replaced file with master branch' version.
- system startup: system/startup.php - fixed DIR_STORAGE constant to see if it has been defined prior to its installation.
- system library document: system/library/document.php - fixed document variable names.
- system library session: system/library/session.php - fixed __destruct() back to: __destroy().
- system library db mysqli: system/library/db/mysqli.php - added validation to close connection with mysqli due to mysqli fetch error.
Install:
- install model upgrade 1009: install/model/upgrade/1009.php - fixed currency, country, event, image, zone, setting, zone to geo zone database tables.
- Added varchar(60) to company fields as per the master branch.
- Added more event queries to switch from addOrderHistory to addHistory as per the master branch.
- Switched from config_limit_admin to config_pagination config key as per the master branch.
-- Addition --
Admin:
- admin startup router controller: admin/controller/startup/router.php: added string type to the route as per the master branch.
- admin language en-gb: admin/language/en-gb/en-gb.php - added button_developer
- admin systems store controller: admin/controller/setting/store.php - added store_total counter and incremented getTotalStores method as per the master branch.
Catalog:
- catalog information contact controller page: catalog/controller/information/contact.php - added $data['text_message'] due to a blank page on the contact success page.
- catalog account translation controller: catalog/controller/account/translation.php - added text_empty language definition.
- catalog product special controller: catalog/controller/product/special.php - added text_empty language definition.
- catalog product category controller: catalog/controller/product/category.php - added text_empty language definition.
- catalog product search controller: catalog/controller/product/search.php - added text_empty language definition.
- catalog product manufacturer controller: catalog/controller/product/manufacturer.php - added text_empty language definition.
- catalog startup router controller: catalog/controller/startup/router.php - added string type to the route as per the master branch.
- catalog model checkout order controller: catalog/model/checkout/order.php - added getOrderRecurring method.
- catalog account recurring controller: catalog/controller/account/recurring.php - added $this->response->addHeader with 404 error.
- catalog account return controller: catalog/controller/account/return.php - added $this->response->addHeader with 404 error.
- catalog checkout cart controller: catalog/controller/checkout/cart.php - added $this->response->addHeader with 404 error.
-- DATABASE FIXES --
- oc_setting
- oc_event
- 'statistics_order_history', 'catalog/model/checkout/order/addOrderHistory/before', 'event/statistics/addOrderHistory'
- 'mail_affiliate_add', 'catalog/model/account/customer/addAffiliate/after', 'mail/affiliate'
- 'mail_affiliate_alert', 'catalog/model/account/customer/addAffiliate/after', 'mail/affiliate/alert'
- 'admin_mail_return', 'admin/model/sale/return/addReturnHistory/after', 'mail/return'
- oc_image
- oc_language
- oc_country
- oc_zone
- oc_zone_to_geo_zone
- oc_user_group - keep the JSON permission strings up-to-date.
- Added escaped '`' containing: name, code and key fields from the models.
-- Page integers --
- All $page = $this->request->get['page']; from all controllers have now been changed to: $page = (int)$this->request->get['page'];
-- install.txt file --
- The install.txt file has been updated with more recent installation steps.
-- upgrade.txt file --
- The upgrade.txt file > troubleshooting now includes step 4.
-- .user.ini file --
Due to the latest compliancy of cPanel (Web Hosting Control Panel), the .user.ini file may be required for most web servers, depending on which cPanel version you may have.
This file has now been included on the package as a duplication file of the php.ini's original file from this package.
-- admin languages and themes for extension/report --
Replaced duplicated text_status with text_order_status or text_recurring_status depending on the situation.
-- catalog double $information_info['title'] --
- catalog/controller/account/register.php
- catalog/controller/account/return.php
- catalog/controller/affiliate/register.php
- catalog/controller/checkout/payment_method.php
- catalog/controller/checkout/register.php
Now using single $information_info['title'] with sprintf.
-- frequencies array move out away from the loops --
- catalog/controller/extension/module/paypal_smart_button.php
- catalog/controller/checkout/confirm.php
- catalog/controller/checkout/cart.php
-- Switching time to datetime where: 'data-date-format="YYYY-MM-DD HH:mm"' are involved --
- catalog/view/theme/default/template/checkout/shipping_address.twig
- catalog/view/theme/default/template/checkout/payment_address.twig
- catalog/view/theme/default/template/checkout/register.twig
- catalog/view/theme/default/template/checkout/guest_shipping.twig
- catalog/view/theme/default/template/checkout/guest.twig
- catalog/view/theme/default/template/checkout/register.twig
- catalog/view/theme/default/template/affiliate/register.twig
- catalog/view/theme/default/template/account/register.twig
- catalog/view/theme/default/template/account/edit.twig
- catalog/view/theme/default/template/account/affiliate.twig
- catalog/view/theme/default/template/account/address_form.twig
-- Affliate terms to: Affiliate --
- Fixed all terms to appropriate terms.
-- Conventional method names --
- Changed all conventional method names from the controllers and models as per the master branch.
-- Pagination controller --
- All new Pagination() class have now been renamed with the new controller convention of: $this->load->controller('common/pagination', array(...)) as per the master branch.
- Removed system/library/pagination.php file (should be removed from the master branch).
- Added admin/controller/common/pagination.php file as per the master branch.
- Added admin/view/template/common/pagination.twig file as per the master branch.
- Added catalog/controller/common/pagination.php file as per the master branch.
- Added catalog/view/template/common/pagination.twig file as per the master branch.
-- Product thumb --
- $this->load->controller('product/thumb', array(...)) has been added as per the master branch.
- Removed old language definitions.
- Merged <div ... by using {{ product }} as per the commit changes.