Confirmed.TonyHolmes wrote:I upgraded from 1.4.8b (the 'b' is not noted at the bottom of the Admin, btw) to 1.4.9, and had a payment through PayPal Standard come through without the Handling Fee attached. The notification emails to the site and the customer both had it included, but the actualy payment that hit my PayPal account did not. Any idea where I can search the code for this one? Not having any luck so far.
FIX:
1. EDIT: catalog/controller/payment/pp_standard.php
2. FIND:
Code: Select all
shipping_2
Code: Select all
handling_cart
What is missing? There is no reference to text_account on the login page. Only for the breadcrumb which is already there.LeorLindel wrote:Hi,
I noticed that it missed in the file upload/catalog/controller/account/login.php:Code: Select all
$this->data['text_account'] = $this->language->get('text_account');
In the file: upload\catalog\view\theme\default\template\account\login.tpl at lign 28Qphoria wrote: What is missing? There is no reference to text_account on the login page. Only for the breadcrumb which is already there.
Code: Select all
<b><?php echo $text_account; ?></b></label>
Tous les packs de langues Française depuis la v1.4.7 et toutes les versions intégrales 100 % Français sont disponibles sur le Portail Officiel Français.
My email addresses are the same, but I have a feeling they do a case-sensitive comparison, so I still get the error as well.Qphoria wrote:If getting emails from paypal that say:This is because you are not using the main email on the paypal account as your opencart paypal account. I did not take this into account initially. The fix is below:PP_Standard - Possible Scam: IPN/PDT Receiver Email does not match seller email. Order needs manual verification
1. EDIT: catalog/controller/payment/pp_standard.php
2. FIND (near the bottom):3. REPLACE WITH:Code: Select all
// verify paypal email matches if (isset($data['receiver_email']) && $data['receiver_email'] != $this->config->get('pp_standard_email')) { $this->error = $this->language->get('error_email_mismatch'); }
Code: Select all
// verify paypal email matches if (isset($data['receiver_email']) && $data['receiver_email'] != $this->config->get('pp_standard_email')) { if (isset($data['business']) && $data['business'] != $this->config->get('pp_standard_email')) { $this->error = $this->language->get('error_email_mismatch'); } }
This was changed to use text_register instead of account. You must be using a 1.4.8 template.LeorLindel wrote:In the file: upload\catalog\view\theme\default\template\account\login.tpl at lign 28Qphoria wrote: What is missing? There is no reference to text_account on the login page. Only for the breadcrumb which is already there.Code: Select all
<b><?php echo $text_account; ?></b></label>
because there one in each page ,and i think I make a mistake ... and I'm a little confuse ...
if possible off course ...
tanks for all.
sorry for my English
Have a look at page 1 of this topicgustavoBRZ wrote:CAN YOU PLEASE ,or someone post all 1.4.9 fixes on one post or page for I make all fixes?
because there one in each page ,and i think I make a mistake ... and I'm a little confuse ...
if possible off course ...
tanks for all.
sorry for my English
Norman in 't Veldt
Moderator OpenCart Forums
_________________ READ and Search BEFORE POSTING _________________
Our FREE search: Find your answer FAST!.
[How to] BTW + Verzend + betaal setup.
I like open cart very much, but there are serious bugs in admin order edit section.
It exists in all add / edit / delete functions, and it is about quantity update.
First of all, I am not sure if it is working (actually I am sure it is not working )
Code: Select all
if( $this->config->get('config_stock_subtract') ){ ..
}
There should be for example in deleteOrder:
Code: Select all
public function deleteOrder($order_id) {
$order_query = $this->db->query("SELECT * FROM `" . DB_PREFIX . "order` WHERE order_status_id > '0' AND order_id = '" . (int)$order_id . "'");
$this->db->query("START TRANSACTION");
if ($order_query->num_rows) {
$product_query = $this->db->query("SELECT * FROM " . DB_PREFIX . "order_product WHERE order_id = '" . (int)$order_id . "'");
foreach($product_query->rows as $product) {
if( $product['subtract'] ){
$this->db->query("UPDATE `" . DB_PREFIX . "product` SET quantity = (quantity + " . (int)$product['quantity'] . ") WHERE product_id = '" . (int)$product['product_id'] . "'");
$option_query = $this->db->query("SELECT * FROM " . DB_PREFIX . "order_option WHERE order_id = '" . (int)$order_id . "' AND order_product_id = '" . (int)$product['order_product_id'] . "'");
foreach ($option_query->rows as $option) {
$this->db->query("UPDATE " . DB_PREFIX . "product_option_value SET quantity = (quantity + " . (int)$product['quantity'] . ") WHERE product_option_value_id = '" . (int)$option['product_option_value_id'] . "' AND subtract = '1'");
}
}
}
}
$this->db->query("DELETE FROM `" . DB_PREFIX . "order` WHERE order_id = '" . (int)$order_id . "'");
$this->db->query("DELETE FROM " . DB_PREFIX . "order_history WHERE order_id = '" . (int)$order_id . "'");
$this->db->query("DELETE FROM " . DB_PREFIX . "order_product WHERE order_id = '" . (int)$order_id . "'");
$this->db->query("DELETE FROM " . DB_PREFIX . "order_option WHERE order_id = '" . (int)$order_id . "'");
$this->db->query("DELETE FROM " . DB_PREFIX . "order_download WHERE order_id = '" . (int)$order_id . "'");
$this->db->query("DELETE FROM " . DB_PREFIX . "order_total WHERE order_id = '" . (int)$order_id . "'");
$this->db->query("COMMIT");
}
in functions
public function addProduct($order_id, $data)
public function removeProduct($order_id, $data)
The first function I had rewrite in 0C 1.48, so above is the correction. The second and the third I will correct later (because they are new in open cart) and paste the solution here.
So, those three functions must be changed ASAP.
Web site development , izrada web sajtova http://www.napravisajt.com/
odmorise wrote:Hi,
I like open cart very much, but there are serious bugs in admin order edit section.
It exists in all add / edit / delete functions, and it is about quantity update.
First of all, I am not sure if it is working (actually I am sure it is not working )Even if it is working, it should not be used, instead of that $product['subtract'] must be the reference !Code: Select all
if( $this->config->get('config_stock_subtract') ){ .. }
There should be for example in deleteOrder:Further, there is no quantity update for products when adding them to order in admin, this should be fixed too.Code: Select all
public function deleteOrder($order_id) { $order_query = $this->db->query("SELECT * FROM `" . DB_PREFIX . "order` WHERE order_status_id > '0' AND order_id = '" . (int)$order_id . "'"); $this->db->query("START TRANSACTION"); if ($order_query->num_rows) { $product_query = $this->db->query("SELECT * FROM " . DB_PREFIX . "order_product WHERE order_id = '" . (int)$order_id . "'"); foreach($product_query->rows as $product) { if( $product['subtract'] ){ $this->db->query("UPDATE `" . DB_PREFIX . "product` SET quantity = (quantity + " . (int)$product['quantity'] . ") WHERE product_id = '" . (int)$product['product_id'] . "'"); $option_query = $this->db->query("SELECT * FROM " . DB_PREFIX . "order_option WHERE order_id = '" . (int)$order_id . "' AND order_product_id = '" . (int)$product['order_product_id'] . "'"); foreach ($option_query->rows as $option) { $this->db->query("UPDATE " . DB_PREFIX . "product_option_value SET quantity = (quantity + " . (int)$product['quantity'] . ") WHERE product_option_value_id = '" . (int)$option['product_option_value_id'] . "' AND subtract = '1'"); } } } } $this->db->query("DELETE FROM `" . DB_PREFIX . "order` WHERE order_id = '" . (int)$order_id . "'"); $this->db->query("DELETE FROM " . DB_PREFIX . "order_history WHERE order_id = '" . (int)$order_id . "'"); $this->db->query("DELETE FROM " . DB_PREFIX . "order_product WHERE order_id = '" . (int)$order_id . "'"); $this->db->query("DELETE FROM " . DB_PREFIX . "order_option WHERE order_id = '" . (int)$order_id . "'"); $this->db->query("DELETE FROM " . DB_PREFIX . "order_download WHERE order_id = '" . (int)$order_id . "'"); $this->db->query("DELETE FROM " . DB_PREFIX . "order_total WHERE order_id = '" . (int)$order_id . "'"); $this->db->query("COMMIT"); }
in functions
public function addProduct($order_id, $data)
public function removeProduct($order_id, $data)
The first function I had rewrite in 0C 1.48, so above is the correction. The second and the third I will correct later (because they are new in open cart) and paste the solution here.
So, those three functions must be changed ASAP.
none of the so called bugs you have described are serious. the admin order editor is a bit flaky bnut ois being completly rewrite for 1.5.0
"Even if it is working, it should not be used, instead of that $product['subtract'] must be the reference !"
Thats your opioin but you don't have the years of experiance that I do!
"$this->db->query("START TRANSACTION");"
We don't use transactions for the orders table for a reason. again you don't have the experiance. If i paypal callback does not go through it means you lost the order
OpenCart®
Project Owner & Developer.
I wouldn't so much call this a bug. It's more a stop-the-stupid user problem
I am able to delete all my products accidentally like this:
1. Go to admin > products
2. Tick the checkbox to select all
3. then enter something in the product name filter and hit [enter]
4. An Alert pops up saying are you sure you want to do this
5. Choose OK
6. All products are deleted
Can the alert be changed to something more meaningful. I read 'do you want to do this' to mean do I want to filter the products when it actually means do you want to delete products.
Maybe the focus can be put on something less dangerous like filter instead of delete
It's the same as it has always been for me (whether I am logged in or not); staying on the product. The only thing I think is missing, which I added for myself, is a 'Go Back' button next to the 'Add to Cart' one.edwinjung wrote:Quick question, when you on the product page and you click "Add to Cart" you're automatically redirected to your cart. Before, it just added the product on the right side and had a moving animation and you stayed on the product page. Is it possible to get it back to that style?
Free v1.4.9 Extensions: Default Specials | Improved Search | Customer Activity Report | Customer Groups | Royal Mail With Handling | Improved Product Page | Random Products | Stock Report | All Products
Exact.Qphoria wrote: This was changed to use text_register instead of account. You must be using a 1.4.8 template.
Thank's
Tous les packs de langues Française depuis la v1.4.7 et toutes les versions intégrales 100 % Français sont disponibles sur le Portail Officiel Français.
I also still have the error. I will change my default email address for the time being, and wait for a fixTonyHolmes wrote:My email addresses are the same, but I have a feeling they do a case-sensitive comparison, so I still get the error as well.Qphoria wrote:If getting emails from paypal that say:This is because you are not using the main email on the paypal account as your opencart paypal account. I did not take this into account initially. The fix is below:PP_Standard - Possible Scam: IPN/PDT Receiver Email does not match seller email. Order needs manual verification
1. EDIT: catalog/controller/payment/pp_standard.php
2. FIND (near the bottom):3. REPLACE WITH:Code: Select all
// verify paypal email matches if (isset($data['receiver_email']) && $data['receiver_email'] != $this->config->get('pp_standard_email')) { $this->error = $this->language->get('error_email_mismatch'); }
Code: Select all
// verify paypal email matches if (isset($data['receiver_email']) && $data['receiver_email'] != $this->config->get('pp_standard_email')) { if (isset($data['business']) && $data['business'] != $this->config->get('pp_standard_email')) { $this->error = $this->language->get('error_email_mismatch'); } }
Both behaviors have been in there for many many versions now. You determine how it will function in the cart module settings in the admin it's called use ajax to add to cart or something like that.edwinjung wrote:Quick question, when you on the product page and you click "Add to Cart" you're automatically redirected to your cart. Before, it just added the product on the right side and had a moving animation and you stayed on the product page. Is it possible to get it back to that style?
OpenCart commercial mods and development http://spotonsolutions.net
Layered Navigation
Shipment Tracking
Vehicle Year/Make/Model Filter
It doesn't create an order in opencart when payment completed.It will appear untill seller capture payment on the PayPal site.
and auto return went wrong if PDT token is filled in.
I changed my default address, and I still get the error in the receipt as well as the email.Topher wrote:I also still have the error. I will change my default email address for the time being, and wait for a fixTonyHolmes wrote: My email addresses are the same, but I have a feeling they do a case-sensitive comparison, so I still get the error as well.
Users browsing this forum: No registered users and 40 guests